Create rule S7112: Const constructors should be invoked with const (prefer_const_constructors) #4363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
antonioaversa
force-pushed
the
rule/add-RSPEC-S7112
branch
from
f2b882d to
4bab500
Compare
antonioaversa
changed the title
leveretka
approved these changes
Oct 3, 2024
rules/S7112/dart/rule.adoc
Outdated
|
|
||
| === Exceptions | ||
|
|
||
| There are scenarios where the `const` keyword is implicitly assumed, and doesn't have to be made explicit. Namely, when the object instantiation happens in a *const context*, there is no need to use the `const` keyword. That is because the Dart compiler is already building a compile-time constant for a larger expression including the object, and a compile-time constant can only be built of other compile-time constants. |
There was a problem hiding this comment.
You can probbably refer to this rule: https://dart.dev/tools/linter-rules/unnecessary_const, as we have it : https://sonarsource.github.io/rspec/#/rspec/S3689/dart
There was a problem hiding this comment.
Done! Also added to the Related rules section under Resources.
antonioaversa
force-pushed
the
rule/add-RSPEC-S7112
branch
from
4bab500 to
85bc851
Compare
…refer_const_constructors)
antonioaversa
force-pushed
the
rule/add-RSPEC-S7112
branch
from
85bc851 to
6c2e804
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: